Mahout
  1. Mahout
  2. MAHOUT-820

Dependency on sjl4j-jcl should not have compile scope

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.6
    • Fix Version/s: 0.6
    • Component/s: build
    • Labels:
      None

      Description

      The top-level pom.xml and integration/pom.xml specify a dependency on slf4j-jcl with default (compile) scope. The point of slf4j is to allow libraries to work with any underlying logging system, leaving the choice up to the application programmer. If my application uses jcl-over-slf4j, and also uses your library which uses slf4j-jcl, initialization fails because there's a logging loop.

      core/pom.xml and math/pom.xml specify slf4j-jcl with test scope only. That's fine, because dependencies with test scope aren't propagated to dependents.

        Activity

        Hide
        Sean Owen added a comment -

        I agree. I see we need to explicitly specify this everywhere. Done.

        Show
        Sean Owen added a comment - I agree. I see we need to explicitly specify this everywhere. Done.
        Hide
        Hudson added a comment -

        Integrated in Mahout-Quality #1065 (See https://builds.apache.org/job/Mahout-Quality/1065/)
        MAHOUT-820 ensure slf4j-jcl is test-only

        srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176456
        Files :

        • /mahout/trunk/integration/pom.xml
        • /mahout/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in Mahout-Quality #1065 (See https://builds.apache.org/job/Mahout-Quality/1065/ ) MAHOUT-820 ensure slf4j-jcl is test-only srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176456 Files : /mahout/trunk/integration/pom.xml /mahout/trunk/pom.xml

          People

          • Assignee:
            Sean Owen
            Reporter:
            Aaron Kaplan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development