Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Not a Problem
    • Affects Version/s: 0.5
    • Fix Version/s: 0.7
    • Component/s: Integration
    • Labels:
      None

      Description

      I get an error building mahout with JDK1.7.0 at
      integration/src/main/java/org/apache/mahout/cf/taste/impl/model/jdbc/ConnectionPoolDataSource.java

        Activity

        Hide
        Hudson added a comment -

        Integrated in Mahout-Quality #1455 (See https://builds.apache.org/job/Mahout-Quality/1455/)
        Add method to support Java 7's terrible decision to make a backwards-incompatible API change here, pointlessly. (MAHOUT-782) (Revision 1332942)

        Result = FAILURE
        srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332942
        Files :

        • /mahout/trunk/integration/src/main/java/org/apache/mahout/cf/taste/impl/model/jdbc/ConnectionPoolDataSource.java
        Show
        Hudson added a comment - Integrated in Mahout-Quality #1455 (See https://builds.apache.org/job/Mahout-Quality/1455/ ) Add method to support Java 7's terrible decision to make a backwards-incompatible API change here, pointlessly. ( MAHOUT-782 ) (Revision 1332942) Result = FAILURE srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1332942 Files : /mahout/trunk/integration/src/main/java/org/apache/mahout/cf/taste/impl/model/jdbc/ConnectionPoolDataSource.java
        Hide
        Sean Owen added a comment -

        You can't apply this patch since it would mean the project doesn't work in Java 6, and Java 6 will be around for years. However I think there's an easy compromise. This method can be implemented and throw SQLFeatureNotSupportedException. It can't @Override. But then it works everywhere. I'll do that.

        Show
        Sean Owen added a comment - You can't apply this patch since it would mean the project doesn't work in Java 6, and Java 6 will be around for years. However I think there's an easy compromise. This method can be implemented and throw SQLFeatureNotSupportedException. It can't @Override. But then it works everywhere. I'll do that.
        Hide
        Shrinivas Joshi added a comment -

        Is there any recent interest in addressing this issue especially after Oracle's announcement to EOL JDK 6? Thanks.

        Show
        Shrinivas Joshi added a comment - Is there any recent interest in addressing this issue especially after Oracle's announcement to EOL JDK 6? Thanks.
        Hide
        Sean Owen added a comment -

        I can't commit this patch since it would not work in Java 6. DataSource does not have a getParentLogger() method, which is both the original problem and why this can't be committed. If you want to experiment with Java 7, indeed you'll have to maintain some local changes like this.

        Show
        Sean Owen added a comment - I can't commit this patch since it would not work in Java 6. DataSource does not have a getParentLogger() method, which is both the original problem and why this can't be committed. If you want to experiment with Java 7, indeed you'll have to maintain some local changes like this.
        Hide
        Ran Hamada added a comment -

        patch

        Show
        Ran Hamada added a comment - patch

          People

          • Assignee:
            Sean Owen
            Reporter:
            Ran Hamada
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development