Mahout
  1. Mahout
  2. MAHOUT-690

LanczosSolver tests take forever. No fun.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.5
    • Fix Version/s: 0.6
    • Component/s: None
    • Labels:
      None

      Description

      Long test runs long.

      Sample output:
      ...
      Running org.apache.mahout.math.hadoop.decomposer.TestDistributedLanczosSolver
      Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 282.859 sec
      ...

      This is very long, and should be improved, if possible.

        Activity

        Jake Mannix created issue -
        Hide
        Sean Owen added a comment -

        Agree, this is over half the test time and does burn a fair bit of time as I run tests frequently.

        One way to speed it up is to shrink the test data size, no? I did so and made it run about 3x faster without causing it to fail, but does this look like it remains a valid test?

        The non-CLI test can be shrunk further but then an assertion about the size of error fails.

        Show
        Sean Owen added a comment - Agree, this is over half the test time and does burn a fair bit of time as I run tests frequently. One way to speed it up is to shrink the test data size, no? I did so and made it run about 3x faster without causing it to fail, but does this look like it remains a valid test? The non-CLI test can be shrunk further but then an assertion about the size of error fails.
        Sean Owen made changes -
        Field Original Value New Value
        Attachment MAHOUT-690.patch [ 12481516 ]
        Sean Owen made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.5 [ 12315255 ]
        Hide
        Hudson added a comment -

        Integrated in Mahout-Quality #872 (See https://builds.apache.org/job/Mahout-Quality/872/)
        MAHOUT-690 reduce test input size to speed up test

        srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1132893
        Files :

        • /mahout/trunk/core/src/test/java/org/apache/mahout/math/hadoop/decomposer/TestDistributedLanczosSolverCLI.java
        • /mahout/trunk/core/src/test/java/org/apache/mahout/math/hadoop/decomposer/TestDistributedLanczosSolver.java
        Show
        Hudson added a comment - Integrated in Mahout-Quality #872 (See https://builds.apache.org/job/Mahout-Quality/872/ ) MAHOUT-690 reduce test input size to speed up test srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1132893 Files : /mahout/trunk/core/src/test/java/org/apache/mahout/math/hadoop/decomposer/TestDistributedLanczosSolverCLI.java /mahout/trunk/core/src/test/java/org/apache/mahout/math/hadoop/decomposer/TestDistributedLanczosSolver.java
        Hide
        Sean Owen added a comment -

        These two together take 46 sec on my laptop after my change – 80% faster. So I think we can call it fixed enough?

        Show
        Sean Owen added a comment - These two together take 46 sec on my laptop after my change – 80% faster. So I think we can call it fixed enough?
        Sean Owen made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Sean Owen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Jake Mannix
            Reporter:
            Jake Mannix
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development