Mahout
  1. Mahout
  2. MAHOUT-46

Refactor AbstractMatrix.COL and ROW to an enumeration

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Cosmetic reasons only.

      Allows for importing the enumeration in any class and use ROW.intValue() instead of AbstractMatrix.ROW.

      Another argument is that an enumeration could hold further meta data, but I don't see any use case.

        Activity

        Karl Wettin created issue -
        Grant Ingersoll made changes -
        Field Original Value New Value
        Workflow jira [ 12429382 ] no-reopen-closed, patch-avail [ 12444689 ]
        Hide
        Sean Owen added a comment -

        Propose we close this as will not fix, mostly on the grounds it was never done. There are lots of usages of these as array indexes, which, yes, must now be followed with ".intValue()" which harms readability a little. This is a small drag on performance too, in what might be some critical sections.

        Show
        Sean Owen added a comment - Propose we close this as will not fix, mostly on the grounds it was never done. There are lots of usages of these as array indexes, which, yes, must now be followed with ".intValue()" which harms readability a little. This is a small drag on performance too, in what might be some critical sections.
        Hide
        Ted Dunning added a comment -


        I think that this idiom will go away naturally as we import/absorb Colt

        Show
        Ted Dunning added a comment - I think that this idiom will go away naturally as we import/absorb Colt
        Sean Owen made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Won't Fix [ 2 ]
        Sean Owen made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Karl Wettin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development