[MAHOUT-223] Infinite loop in Vector.haveSharedCells(Vector)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.2
• Fix Version/s: 0.3
• Component/s: classic
• Assignee: Sean R. Owen
• Reporter: Jake Mannix
• Created: 15/Dec/09 04:57
• Updated: 31/Jan/24 22:16
• Resolved: 22/Dec/09 13:49

Description

SparseVector:

  @Override
  public boolean haveSharedCells(Vector other) {
    if (other instanceof SparseVector) {
      return other == this;
    } else {
      return other.haveSharedCells(this);
    }
  }

DenseVector:

  @Override
  public boolean haveSharedCells(Vector other) {
    if (other instanceof DenseVector) {
      return other == this;
    } else {
      return other.haveSharedCells(this);
    }
  }

I think the result is self-explanatory.

I'd just check a fix in, but I don't have an svn account yet. Actually, no I wouldn't because I'm not exactly sure what this method is supposed to do - it's clearly for VectorView instances somehow... but what about Sparse and Dense versions on the same vector (same meaning strictEquivalent() returns true for them)?