[MAHOUT-213] storeMapping should not been called when toLongID() is called

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.3
• Fix Version/s: 0.3
• Assignee: Sean R. Owen
• Reporter: Jeff Zhang
• Created: 08/Dec/09 07:57
• Updated: 31/Jan/24 22:11
• Resolved: 08/Dec/09 12:19

Description

In the trunk, storeMapping is called always when toLongID() is called. In my opinion storeMapping should been called only in method initialize().
storeMapping will cost a lot when you use database to store the id mapping. I believe the code should like this:

  public void initialize(Iterable<String> stringIDs) throws TasteException {
    for (String stringID : stringIDs) {
      long longID = hash(stringID);
      storeMapping(longID, stringID);
    }
  }