Uploaded image for project: 'Mahout'
  1. Mahout
  2. MAHOUT-1999

Automate Release Process with Build Script

    Details

    • Type: Improvement
    • Status: In Progress
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 0.13.2
    • Fix Version/s: None
    • Component/s: build
    • Labels:
      None

      Description

      With the proliferation of binaries across multiple Scala / Spark versions- a release script should be implemented to support multiple builds.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Mahout-Quality #3505 (See https://builds.apache.org/job/Mahout-Quality/3505/)
          MAHOUT-1999 Automate Multi-artifact release (rawkintrevo: rev 8c14b309cb4319cb304b68328bc646a3ec48f55d)

          • (add) distribution/src/main/assembly/scala-2.11_spark-2.0.xml
          • (add) distribution/src/main/assembly/scala-2.11_spark-2.1.xml
          • (delete) distribution/src/main/assembly/bin.xml
          • (edit) website/oldsite/developers/how-to-release.md
          • (add) buildtools/build-all-release-jars.sh
          • (edit) distribution/pom.xml
          • (edit) pom.xml
          • (add) distribution/src/main/assembly/scala-2.10_spark-1.6.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Mahout-Quality #3505 (See https://builds.apache.org/job/Mahout-Quality/3505/ ) MAHOUT-1999 Automate Multi-artifact release (rawkintrevo: rev 8c14b309cb4319cb304b68328bc646a3ec48f55d) (add) distribution/src/main/assembly/scala-2.11_spark-2.0.xml (add) distribution/src/main/assembly/scala-2.11_spark-2.1.xml (delete) distribution/src/main/assembly/bin.xml (edit) website/oldsite/developers/how-to-release.md (add) buildtools/build-all-release-jars.sh (edit) distribution/pom.xml (edit) pom.xml (add) distribution/src/main/assembly/scala-2.10_spark-1.6.xml
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user rawkintrevo opened a pull request:

          https://github.com/apache/mahout/pull/350

          [WIP] MAHOUT-1999 Multi artifact build

              1. Purpose of PR:

          Build multiple binaries of spark in one maven shot.

          The issues surrounding SBT wrt MAHOUT-2020 continue, however the produced artifacts work fine for maven builds, as well as console/Zeppelin integrations.

          In short- the distribution module executes `mvn package` twice more, with Scala-2.11/SPark-2.0 and Scala-2.11/SPark-2.1 switches.

          *WHy is this WIP?* We need a way to prevent it from happening on every run. Imho, the distribution module should be disabled for 'automatically' running. Docs will need to be updated accordingly.

              1. Important ToDos
                Please mark each with an "x"
          • [x] A JIRA ticket exists (if not, please create this first)https://issues.apache.org/jira/browse/ZEPPELIN/
          • [x] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
          • [x] Created unit tests where appropriate
          • [x] Added licenses correct on newly added files
          • [x] Assigned JIRA to self
          • [ ] Added documentation in scala docs/java docs, and to website
          • [x] Successfully built and ran all unit tests, verified that all tests pass locally.

          If all of these things aren't complete, but you still feel it is
          appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
          descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"

          Does this change break earlier versions?

          Is this the beginning of a larger project for which a feature branch should be made?

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/rawkintrevo/mahout mahout-1999-b

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/mahout/pull/350.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #350


          commit d4eb83acba2022e9fb21ec6d1ded1d2e3e05ea25
          Author: Trevor a.k.a @rawkintrevo <trevor.d.grant@gmail.com>
          Date: 2017-11-05T23:38:40Z

          MAHOUT-1999 Multi artifact build


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user rawkintrevo opened a pull request: https://github.com/apache/mahout/pull/350 [WIP] MAHOUT-1999 Multi artifact build Purpose of PR: Build multiple binaries of spark in one maven shot. The issues surrounding SBT wrt MAHOUT-2020 continue, however the produced artifacts work fine for maven builds, as well as console/Zeppelin integrations. In short- the distribution module executes `mvn package` twice more, with Scala-2.11/SPark-2.0 and Scala-2.11/SPark-2.1 switches. * WHy is this WIP? * We need a way to prevent it from happening on every run. Imho, the distribution module should be disabled for 'automatically' running. Docs will need to be updated accordingly. Important ToDos Please mark each with an "x" [x] A JIRA ticket exists (if not, please create this first) https://issues.apache.org/jira/browse/ZEPPELIN/ [x] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number. [x] Created unit tests where appropriate [x] Added licenses correct on newly added files [x] Assigned JIRA to self [ ] Added documentation in scala docs/java docs, and to website [x] Successfully built and ran all unit tests, verified that all tests pass locally. If all of these things aren't complete, but you still feel it is appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change" Does this change break earlier versions? Is this the beginning of a larger project for which a feature branch should be made? You can merge this pull request into a Git repository by running: $ git pull https://github.com/rawkintrevo/mahout mahout-1999-b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/mahout/pull/350.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #350 commit d4eb83acba2022e9fb21ec6d1ded1d2e3e05ea25 Author: Trevor a.k.a @rawkintrevo <trevor.d.grant@gmail.com> Date: 2017-11-05T23:38:40Z MAHOUT-1999 Multi artifact build
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user andrewpalumbo commented on the issue:

          https://github.com/apache/mahout/pull/350

          @rawkintrevo Which build command should we be testing?

          Show
          githubbot ASF GitHub Bot added a comment - Github user andrewpalumbo commented on the issue: https://github.com/apache/mahout/pull/350 @rawkintrevo Which build command should we be testing?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user andrewpalumbo commented on a diff in the pull request:

          https://github.com/apache/mahout/pull/350#discussion_r149564984

          — Diff: distribution/pom.xml —
          @@ -39,6 +39,131 @@
          <artifactId>exec-maven-plugin</artifactId>
          <version>1.1.1</version>
          <executions>
          + <!-- Various Scalas -->
          + <execution>
          — End diff –

          not getting `viennacl(S)` with mvn clean install Pdistribution (though maybe this is not needed? looks like its is only in the `package` arg. Doesn't seem like an issue but raising point.

          Show
          githubbot ASF GitHub Bot added a comment - Github user andrewpalumbo commented on a diff in the pull request: https://github.com/apache/mahout/pull/350#discussion_r149564984 — Diff: distribution/pom.xml — @@ -39,6 +39,131 @@ <artifactId>exec-maven-plugin</artifactId> <version>1.1.1</version> <executions> + <!-- Various Scalas --> + <execution> — End diff – not getting `viennacl(S)` with mvn clean install Pdistribution (though maybe this is not needed? looks like its is only in the `package` arg. Doesn't seem like an issue but raising point.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user andrewpalumbo commented on a diff in the pull request:

          https://github.com/apache/mahout/pull/350#discussion_r149565346

          — Diff: distribution/pom.xml —
          @@ -39,6 +39,131 @@
          <artifactId>exec-maven-plugin</artifactId>
          <version>1.1.1</version>
          <executions>
          + <!-- Various Scalas -->
          + <execution>
          — End diff –

          Checked again with `mvn clean package -Pdistribution`:
          ```
          mvn clean package -Pdistribution
          [INFO] Scanning for projects...
          [WARNING]
          [WARNING] Some problems were encountered while building the effective model for org.apache.mahout:mahout-math:jar:0.13.1-SNAPSHOT
          [WARNING] The expression $

          {version} is deprecated. Please use ${project.version} instead.
          [WARNING] The expression ${version}

          is deprecated. Please use $

          {project.version} instead.
          [WARNING]
          [WARNING] Some problems were encountered while building the effective model for org.apache.mahout:mahout-hdfs:jar:0.13.1-SNAPSHOT
          [WARNING] The expression ${version} is deprecated. Please use ${project.version}

          instead.
          [WARNING] The expression $

          {version} is deprecated. Please use ${project.version} instead.
          [WARNING]
          [WARNING] Some problems were encountered while building the effective model for org.apache.mahout:mahout-mr:jar:0.13.1-SNAPSHOT
          [WARNING] The expression ${version}

          is deprecated. Please use $

          {project.version} instead.
          [WARNING] The expression ${version} is deprecated. Please use ${project.version}

          instead.
          [WARNING]
          [WARNING] Some problems were encountered while building the effective model for org.apache.mahout:mahout-math-scala_2.10:jar:0.13.1-SNAPSHOT
          [WARNING] 'artifactId' contains an expression but should be a constant. @ org.apache.mahout:mahout-math-scala_$

          {scala.compat.version}:[unknown-version], /home/andy/sandbox/mahout_cuda/math-scala/pom.xml, line 30, column 15
          [WARNING] The expression ${version} is deprecated. Please use ${project.version} instead.
          [WARNING] The expression ${version} is deprecated. Please use ${project.version} instead.
          [WARNING]
          [WARNING] Some problems were encountered while building the effective model for org.apache.mahout:mahout-spark_2.10:jar:0.13.1-SNAPSHOT
          [WARNING] 'artifactId' contains an expression but should be a constant. @ org.apache.mahout:mahout-spark_${scala.compat.version}

          :[unknown-version], /home/andy/sandbox/mahout_cuda/spark/pom.xml, line 30, column 15
          [WARNING] The expression $

          {version} is deprecated. Please use ${project.version} instead.
          [WARNING] The expression ${version}

          is deprecated. Please use $

          {project.version} instead.
          [WARNING] The expression ${version} is deprecated. Please use ${project.version}

          instead.
          [WARNING] The expression $

          {version} is deprecated. Please use ${project.version} instead.
          [WARNING]
          [WARNING] Some problems were encountered while building the effective model for org.apache.mahout:mahout-h2o_2.10:jar:0.13.1-SNAPSHOT
          [WARNING] 'artifactId' contains an expression but should be a constant. @ org.apache.mahout:mahout-h2o_${scala.compat.version}:[unknown-version], /home/andy/sandbox/mahout_cuda/h2o/pom.xml, line 30, column 15
          [WARNING] The expression ${version}

          is deprecated. Please use $

          {project.version} instead.
          [WARNING] The expression ${version} is deprecated. Please use ${project.version}

          instead.
          [WARNING]
          [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
          [WARNING]
          [WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
          [WARNING]
          [INFO] ------------------------------------------------------------------------
          [INFO] Reactor Build Order:
          [INFO]
          [INFO] Mahout Build Tools
          [INFO] Apache Mahout
          [INFO] Mahout Math
          [INFO] Mahout HDFS
          [INFO] Mahout Map-Reduce
          [INFO] Mahout Integration
          [INFO] Mahout Examples
          [INFO] Mahout Math Scala bindings
          [INFO] Mahout Spark bindings
          [INFO] Mahout H2O backend
          [INFO] Mahout Release Package
          ```
          No `viennacl`

          Show
          githubbot ASF GitHub Bot added a comment - Github user andrewpalumbo commented on a diff in the pull request: https://github.com/apache/mahout/pull/350#discussion_r149565346 — Diff: distribution/pom.xml — @@ -39,6 +39,131 @@ <artifactId>exec-maven-plugin</artifactId> <version>1.1.1</version> <executions> + <!-- Various Scalas --> + <execution> — End diff – Checked again with `mvn clean package -Pdistribution`: ``` mvn clean package -Pdistribution [INFO] Scanning for projects... [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.mahout:mahout-math:jar:0.13.1-SNAPSHOT [WARNING] The expression $ {version} is deprecated. Please use ${project.version} instead. [WARNING] The expression ${version} is deprecated. Please use $ {project.version} instead. [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.mahout:mahout-hdfs:jar:0.13.1-SNAPSHOT [WARNING] The expression ${version} is deprecated. Please use ${project.version} instead. [WARNING] The expression $ {version} is deprecated. Please use ${project.version} instead. [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.mahout:mahout-mr:jar:0.13.1-SNAPSHOT [WARNING] The expression ${version} is deprecated. Please use $ {project.version} instead. [WARNING] The expression ${version} is deprecated. Please use ${project.version} instead. [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.mahout:mahout-math-scala_2.10:jar:0.13.1-SNAPSHOT [WARNING] 'artifactId' contains an expression but should be a constant. @ org.apache.mahout:mahout-math-scala_$ {scala.compat.version}: [unknown-version] , /home/andy/sandbox/mahout_cuda/math-scala/pom.xml, line 30, column 15 [WARNING] The expression ${version} is deprecated. Please use ${project.version} instead. [WARNING] The expression ${version} is deprecated. Please use ${project.version} instead. [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.mahout:mahout-spark_2.10:jar:0.13.1-SNAPSHOT [WARNING] 'artifactId' contains an expression but should be a constant. @ org.apache.mahout:mahout-spark_${scala.compat.version} : [unknown-version] , /home/andy/sandbox/mahout_cuda/spark/pom.xml, line 30, column 15 [WARNING] The expression $ {version} is deprecated. Please use ${project.version} instead. [WARNING] The expression ${version} is deprecated. Please use $ {project.version} instead. [WARNING] The expression ${version} is deprecated. Please use ${project.version} instead. [WARNING] The expression $ {version} is deprecated. Please use ${project.version} instead. [WARNING] [WARNING] Some problems were encountered while building the effective model for org.apache.mahout:mahout-h2o_2.10:jar:0.13.1-SNAPSHOT [WARNING] 'artifactId' contains an expression but should be a constant. @ org.apache.mahout:mahout-h2o_${scala.compat.version}: [unknown-version] , /home/andy/sandbox/mahout_cuda/h2o/pom.xml, line 30, column 15 [WARNING] The expression ${version} is deprecated. Please use $ {project.version} instead. [WARNING] The expression ${version} is deprecated. Please use ${project.version} instead. [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING] [INFO] ------------------------------------------------------------------------ [INFO] Reactor Build Order: [INFO] [INFO] Mahout Build Tools [INFO] Apache Mahout [INFO] Mahout Math [INFO] Mahout HDFS [INFO] Mahout Map-Reduce [INFO] Mahout Integration [INFO] Mahout Examples [INFO] Mahout Math Scala bindings [INFO] Mahout Spark bindings [INFO] Mahout H2O backend [INFO] Mahout Release Package ``` No `viennacl`
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user andrewpalumbo commented on a diff in the pull request:

          https://github.com/apache/mahout/pull/350#discussion_r149566522

          — Diff: pom.xml —
          @@ -586,7 +586,7 @@
          <version>2.5.2</version>
          <configuration>
          <useReleaseProfile>true</useReleaseProfile>

          • <releaseProfiles>mahout-release,apache-release,hadoop2</releaseProfiles>
            + <releaseProfiles>distribution,mahout-release,apache-release,hadoop2</releaseProfiles>
              • End diff –

          Add `viennacl-omp here?` this would kick off both`viennacl`, and `viennacl-omp`

          Show
          githubbot ASF GitHub Bot added a comment - Github user andrewpalumbo commented on a diff in the pull request: https://github.com/apache/mahout/pull/350#discussion_r149566522 — Diff: pom.xml — @@ -586,7 +586,7 @@ <version>2.5.2</version> <configuration> <useReleaseProfile>true</useReleaseProfile> <releaseProfiles>mahout-release,apache-release,hadoop2</releaseProfiles> + <releaseProfiles>distribution,mahout-release,apache-release,hadoop2</releaseProfiles> End diff – Add `viennacl-omp here?` this would kick off both`viennacl`, and `viennacl-omp`
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user andrewpalumbo commented on a diff in the pull request:

          https://github.com/apache/mahout/pull/350#discussion_r149566271

          — Diff: distribution/pom.xml —
          @@ -39,6 +39,131 @@
          <artifactId>exec-maven-plugin</artifactId>
          <version>1.1.1</version>
          <executions>
          + <!-- Various Scalas -->
          + <execution>
          — End diff –

          builds cleanly for `scala-2.11.6`:
          ```mvn clean install -Dscala.compat.version=2.11 -Dscala.version=2.11.6 -Pviennacl -DskipTests``` running tests now..

          Show
          githubbot ASF GitHub Bot added a comment - Github user andrewpalumbo commented on a diff in the pull request: https://github.com/apache/mahout/pull/350#discussion_r149566271 — Diff: distribution/pom.xml — @@ -39,6 +39,131 @@ <artifactId>exec-maven-plugin</artifactId> <version>1.1.1</version> <executions> + <!-- Various Scalas --> + <execution> — End diff – builds cleanly for `scala-2.11.6`: ```mvn clean install -Dscala.compat.version=2.11 -Dscala.version=2.11.6 -Pviennacl -DskipTests``` running tests now..
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user andrewpalumbo commented on a diff in the pull request:

          https://github.com/apache/mahout/pull/350#discussion_r149572241

          — Diff: distribution/pom.xml —
          @@ -39,6 +39,131 @@
          <artifactId>exec-maven-plugin</artifactId>
          <version>1.1.1</version>
          <executions>
          + <!-- Various Scalas -->
          + <execution>
          — End diff –

          all tests pass for me with ```mvn clean install -Dscala.compat.version=2.11 -Dscala.version=2.11.6 -Pviennacl -DskipTests && mvn test -Dscala.compat.version=2.11 -Dscala.version=2.11.6 -Pviennacl
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user andrewpalumbo commented on a diff in the pull request: https://github.com/apache/mahout/pull/350#discussion_r149572241 — Diff: distribution/pom.xml — @@ -39,6 +39,131 @@ <artifactId>exec-maven-plugin</artifactId> <version>1.1.1</version> <executions> + <!-- Various Scalas --> + <execution> — End diff – all tests pass for me with ```mvn clean install -Dscala.compat.version=2.11 -Dscala.version=2.11.6 -Pviennacl -DskipTests && mvn test -Dscala.compat.version=2.11 -Dscala.version=2.11.6 -Pviennacl ```
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user andrewpalumbo commented on a diff in the pull request:

          https://github.com/apache/mahout/pull/350#discussion_r149566694

          — Diff: pom.xml —
          @@ -842,13 +842,22 @@
          <module>mr</module>
          <module>integration</module>
          <module>examples</module>

          • <module>distribution</module>
            +
            <module>math-scala</module>
            <module>spark</module>
            <module>h2o</module>
            </modules>

          <profiles>
          + <profile>
          + <id>distribution</id>
          + <activation>
          + <activeByDefault>true</activeByDefault>
          — End diff –

          this, I would think should default to false.

          Show
          githubbot ASF GitHub Bot added a comment - Github user andrewpalumbo commented on a diff in the pull request: https://github.com/apache/mahout/pull/350#discussion_r149566694 — Diff: pom.xml — @@ -842,13 +842,22 @@ <module>mr</module> <module>integration</module> <module>examples</module> <module>distribution</module> + <module>math-scala</module> <module>spark</module> <module>h2o</module> </modules> <profiles> + <profile> + <id>distribution</id> + <activation> + <activeByDefault>true</activeByDefault> — End diff – this, I would think should default to false.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user pferrel commented on the issue:

          https://github.com/apache/mahout/pull/350

          We need a matrix if profiles and important -D options, also what is the default, IMO is should be Spark 2.1 at least and Scala 2.11, these are reasonably recent CDH distros and are forward compatible with Spark 2.3 with Hadoop 2.8, which is what I'm running (as opposed to building for).

          `mvn clean install -Dspark.version=spark-2.2.0 -Dspark.compat.version=2.0 -Dscala.compat.version=2.11 -Dscala.version=2.11.11`

          test running...

          Show
          githubbot ASF GitHub Bot added a comment - Github user pferrel commented on the issue: https://github.com/apache/mahout/pull/350 We need a matrix if profiles and important -D options, also what is the default, IMO is should be Spark 2.1 at least and Scala 2.11, these are reasonably recent CDH distros and are forward compatible with Spark 2.3 with Hadoop 2.8, which is what I'm running (as opposed to building for). `mvn clean install -Dspark.version=spark-2.2.0 -Dspark.compat.version=2.0 -Dscala.compat.version=2.11 -Dscala.version=2.11.11` test running...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user pferrel commented on the issue:

          https://github.com/apache/mahout/pull/350

          BTW if this works I'll test the speedup PR too and merge it. Only my test app needed Scala 2.11, the speedup doesn't care.

          Show
          githubbot ASF GitHub Bot added a comment - Github user pferrel commented on the issue: https://github.com/apache/mahout/pull/350 BTW if this works I'll test the speedup PR too and merge it. Only my test app needed Scala 2.11, the speedup doesn't care.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user pferrel commented on the issue:

          https://github.com/apache/mahout/pull/350

          -Dspark.version=spark-2.2.0 failed `[WARNING] The POM for org.apache.spark:spark-core_2.11:jar:spark-2.2.0 is missing, no dependency information available`

          2.2.0 is the default download from the Spark site.

          Trying `Dspark.version=spark-2.1.0` Do any intermediate ones build or are the versions hard coded not based on the passed in string?

          Show
          githubbot ASF GitHub Bot added a comment - Github user pferrel commented on the issue: https://github.com/apache/mahout/pull/350 -Dspark.version=spark-2.2.0 failed ` [WARNING] The POM for org.apache.spark:spark-core_2.11:jar:spark-2.2.0 is missing, no dependency information available` 2.2.0 is the default download from the Spark site. Trying `Dspark.version=spark-2.1.0` Do any intermediate ones build or are the versions hard coded not based on the passed in string?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user pferrel commented on the issue:

          https://github.com/apache/mahout/pull/350

          Hmm `mvn clean install -Dspark.version=spark-2.1.0 -Dspark.compat.version=2.0 -Dscala.compat.version=2.11 -Dscala.version=2.11.11` also fails `[WARNING] The POM for org.apache.spark:spark-core_2.11:jar:spark-2.1.0 is missing, no dependency information available`

          Show
          githubbot ASF GitHub Bot added a comment - Github user pferrel commented on the issue: https://github.com/apache/mahout/pull/350 Hmm `mvn clean install -Dspark.version=spark-2.1.0 -Dspark.compat.version=2.0 -Dscala.compat.version=2.11 -Dscala.version=2.11.11` also fails ` [WARNING] The POM for org.apache.spark:spark-core_2.11:jar:spark-2.1.0 is missing, no dependency information available`
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user pferrel commented on the issue:

          https://github.com/apache/mahout/pull/350

          looks like this should be closed and #350 should be used instead

          Show
          githubbot ASF GitHub Bot added a comment - Github user pferrel commented on the issue: https://github.com/apache/mahout/pull/350 looks like this should be closed and #350 should be used instead
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user pferrel commented on the issue:

          https://github.com/apache/mahout/pull/350

          Hmm got the wrong branch, missed "-b"
          nevermind

          Show
          githubbot ASF GitHub Bot added a comment - Github user pferrel commented on the issue: https://github.com/apache/mahout/pull/350 Hmm got the wrong branch, missed "-b" nevermind
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rawkintrevo commented on a diff in the pull request:

          https://github.com/apache/mahout/pull/350#discussion_r151248586

          — Diff: distribution/pom.xml —
          @@ -39,6 +39,131 @@
          <artifactId>exec-maven-plugin</artifactId>
          <version>1.1.1</version>
          <executions>
          + <!-- Various Scalas -->
          + <execution>
          — End diff –

          `mvn clean install -Pviennacl,viennacl-omp,distribution`

          There are executions to pick up multiple scala versions of both in `Pdistribution`

          Show
          githubbot ASF GitHub Bot added a comment - Github user rawkintrevo commented on a diff in the pull request: https://github.com/apache/mahout/pull/350#discussion_r151248586 — Diff: distribution/pom.xml — @@ -39,6 +39,131 @@ <artifactId>exec-maven-plugin</artifactId> <version>1.1.1</version> <executions> + <!-- Various Scalas --> + <execution> — End diff – `mvn clean install -Pviennacl,viennacl-omp,distribution` There are executions to pick up multiple scala versions of both in `Pdistribution`
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rawkintrevo commented on a diff in the pull request:

          https://github.com/apache/mahout/pull/350#discussion_r151248739

          — Diff: pom.xml —
          @@ -586,7 +586,7 @@
          <version>2.5.2</version>
          <configuration>
          <useReleaseProfile>true</useReleaseProfile>

          • <releaseProfiles>mahout-release,apache-release,hadoop2</releaseProfiles>
            + <releaseProfiles>distribution,mahout-release,apache-release,hadoop2</releaseProfiles>
              • End diff –

          yes I think it's reasonable to do that.

          Show
          githubbot ASF GitHub Bot added a comment - Github user rawkintrevo commented on a diff in the pull request: https://github.com/apache/mahout/pull/350#discussion_r151248739 — Diff: pom.xml — @@ -586,7 +586,7 @@ <version>2.5.2</version> <configuration> <useReleaseProfile>true</useReleaseProfile> <releaseProfiles>mahout-release,apache-release,hadoop2</releaseProfiles> + <releaseProfiles>distribution,mahout-release,apache-release,hadoop2</releaseProfiles> End diff – yes I think it's reasonable to do that.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rawkintrevo commented on a diff in the pull request:

          https://github.com/apache/mahout/pull/350#discussion_r151249466

          — Diff: pom.xml —
          @@ -842,13 +842,22 @@
          <module>mr</module>
          <module>integration</module>
          <module>examples</module>

          • <module>distribution</module>
            +
            <module>math-scala</module>
            <module>spark</module>
            <module>h2o</module>
            </modules>

          <profiles>
          + <profile>
          + <id>distribution</id>
          + <activation>
          + <activeByDefault>true</activeByDefault>
          — End diff –

          agreed updated

          Show
          githubbot ASF GitHub Bot added a comment - Github user rawkintrevo commented on a diff in the pull request: https://github.com/apache/mahout/pull/350#discussion_r151249466 — Diff: pom.xml — @@ -842,13 +842,22 @@ <module>mr</module> <module>integration</module> <module>examples</module> <module>distribution</module> + <module>math-scala</module> <module>spark</module> <module>h2o</module> </modules> <profiles> + <profile> + <id>distribution</id> + <activation> + <activeByDefault>true</activeByDefault> — End diff – agreed updated
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user andrewpalumbo commented on a diff in the pull request:

          https://github.com/apache/mahout/pull/350#discussion_r151251002

          — Diff: distribution/pom.xml —
          @@ -39,6 +39,131 @@
          <artifactId>exec-maven-plugin</artifactId>
          <version>1.1.1</version>
          <executions>
          + <!-- Various Scalas -->
          + <execution>
          — End diff –

          👍

          Show
          githubbot ASF GitHub Bot added a comment - Github user andrewpalumbo commented on a diff in the pull request: https://github.com/apache/mahout/pull/350#discussion_r151251002 — Diff: distribution/pom.xml — @@ -39,6 +39,131 @@ <artifactId>exec-maven-plugin</artifactId> <version>1.1.1</version> <executions> + <!-- Various Scalas --> + <execution> — End diff – 👍
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user pferrel commented on the issue:

          https://github.com/apache/mahout/pull/350

          This tests out for me. Merge away

          Show
          githubbot ASF GitHub Bot added a comment - Github user pferrel commented on the issue: https://github.com/apache/mahout/pull/350 This tests out for me. Merge away
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/mahout/pull/350

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/mahout/pull/350

            People

            • Assignee:
              rawkintrevo Trevor Grant
              Reporter:
              rawkintrevo Trevor Grant
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development