[MAHOUT-1739] maxSimilarItemsPerItem param of ItemSimilarityJob doesn't behave correct

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 0.10.0
• Labels: easyfix patch
• Assignee: Unassigned
• Reporter: lariven
• Created: 12/Jun/15 14:49
• Updated: 31/Jan/24 22:12
• Resolved: 14/Jun/15 08:37

Description

the output similar items of ItemSimilarityJob for each target item may exceed the number of similar items we set to maxSimilarItemsPerItem parameter. the following code of ItemSimilarityJob.java about line NO. 200 may affect:
if (itemID < otherItemID)

{ ctx.write(new EntityEntityWritable(itemID, otherItemID), new DoubleWritable(similarItem.getSimilarity())); }

else

{ ctx.write(new EntityEntityWritable(otherItemID, itemID), new DoubleWritable(similarItem.getSimilarity())); }

Don't know why need to switch itemID with otherItemID, but I think a single line is enough:
ctx.write(new EntityEntityWritable(itemID, otherItemID), new DoubleWritable(similarItem.getSimilarity()));