[MAHOUT-1303] GenericItemBasedRecommender.estimate(id) method confusing (line 347-349)

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: 0.9
• Fix Version/s: 0.9
• Component/s: Collaborative Filtering
• Assignee: Suneel Marthi
• Reporter: chsz wu
• Created: 06/Aug/13 23:08
• Updated: 03/Feb/14 07:57
• Resolved: 18/Oct/13 08:04

Description

--------
if (excludeItemIfNotSimilarToAll || !Double.isNaN(estimate))

{ -- line 347 average.addDatum(estimate); }

---

line 347 seems logic confusing,

if excludeItemIfNotSimilarToAll == true, -> always add data into average, doesn't matter what the data is , Nan ???