[MAHOUT-1015] Precondition check in IRStatisticsImpl broken

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 0.7
• Assignee: Sean R. Owen
• Reporter: Robert Jäschke
• Created: 16/May/12 09:58
• Updated: 31/Jan/24 22:11
• Resolved: 16/May/12 10:36

Description

The precondition check in the constructor of org.apache.mahout.cf.taste.impl.eval.IRStatisticsImpl includes Copy&Paste errors:

Preconditions.checkArgument(fallOut >= 0.0 && fallOut <= 1.0, "Illegal fallOut: " + fallOut);
Preconditions.checkArgument(fallOut >= 0.0 && fallOut <= 1.0, "Illegal nDCG: " + ndcg);
Preconditions.checkArgument(reach >= 0.0 && reach <= 1.0, "Illegal reach: " + ndcg);

The second line shows a message for nDCG but checks the fallOut, the third line checks the reach but prints out the nDCG.

This error is also in the current version from the SVN (http://svn.apache.org/viewvc/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/IRStatisticsImpl.java?revision=1213930&view=markup)