Lucy
  1. Lucy
  2. LUCY-205

Parallel processing for SearchServer

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.3.0 (incubating)
    • Component/s: Search
    • Labels:
      None

      Description

      The SearchServer should be able to serve multiple client connections in parallel.

      1. LUCY-205-v2.patch
        8 kB
        Nick Wellnhofer
      2. LUCY-205.patch
        11 kB
        Nick Wellnhofer

        Activity

        Nick Wellnhofer created issue -
        Hide
        Nick Wellnhofer added a comment - - edited

        Patch LUCY-205.patch rewrites the SearchServer to use Net::Server::PreFork

        Show
        Nick Wellnhofer added a comment - - edited Patch LUCY-205 .patch rewrites the SearchServer to use Net::Server::PreFork
        Nick Wellnhofer made changes -
        Field Original Value New Value
        Attachment LUCY-205.patch [ 12508471 ]
        Hide
        Nick Wellnhofer added a comment -

        LUCY-205-v2.patch is a second attempt that changes the SearchServer only slightly.

        • The port parameter is moved from the constructor to the serve method.
        • The request handling is split from the serve method into a new method handle_request.

        With these changes the SearchServer can be better integrated into external server applications.

        Show
        Nick Wellnhofer added a comment - LUCY-205 -v2.patch is a second attempt that changes the SearchServer only slightly. The port parameter is moved from the constructor to the serve method. The request handling is split from the serve method into a new method handle_request . With these changes the SearchServer can be better integrated into external server applications.
        Nick Wellnhofer made changes -
        Attachment LUCY-205-v2.patch [ 12508976 ]
        Hide
        Marvin Humphrey added a comment -

        +1 to commit!

        This does change the public API, though in terms of content it is
        not a risky patch. +1 to sneak this in to the 0.3 branch before
        0.3.0 gets cut, if the stars align. And then it would also be nice to
        do away with "password" since we're already breaking back compat.

        Show
        Marvin Humphrey added a comment - +1 to commit! This does change the public API, though in terms of content it is not a risky patch. +1 to sneak this in to the 0.3 branch before 0.3.0 gets cut, if the stars align. And then it would also be nice to do away with "password" since we're already breaking back compat.
        Hide
        Nick Wellnhofer added a comment -

        Fixed in r1226462. I also removed the search server password in r1226473.

        Show
        Nick Wellnhofer added a comment - Fixed in r1226462. I also removed the search server password in r1226473.
        Nick Wellnhofer made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Nick Wellnhofer made changes -
        Fix Version/s 0.3.0 (incubating) [ 12317044 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        10d 16h 47m 1 Nick Wellnhofer 02/Jan/12 17:04

          People

          • Assignee:
            Nick Wellnhofer
            Reporter:
            Nick Wellnhofer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development