Lucy
  1. Lucy
  2. LUCY-160

Always disable symlink tests on Windows

    Details

      Description

      The enabling of test_preserve_symlinks() test in TestFSFolder.c has heretofore
      been keyed off of the existence of the unistd.h header file. This has caused
      errors under Strawberry Perl, which provides the unistd.h header but without a
      symlink() function. The solution is to disable the test based on whether the
      _WIN32 symbol is defined.

      We also add a test which uses windows.h and CreateSymbolicLink() rather than
      unistd.h and symlink(). However it must remain disabled by default, since
      CreateSymbolicLink() fails unless the user running the test has administrator
      privileges.

        Activity

        Hide
        Marvin Humphrey added a comment -

        Fix committed to trunk as r1139709, but still needs to be merged to the
        0.1 branch.

        Show
        Marvin Humphrey added a comment - Fix committed to trunk as r1139709, but still needs to be merged to the 0.1 branch.

          People

          • Assignee:
            Marvin Humphrey
            Reporter:
            Marvin Humphrey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development