Lucene.Net
  1. Lucene.Net
  2. LUCENENET-487

Remove Obsolete Members, Fields that are marked as obsolete and to be removed in 3.0

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: Lucene.Net 3.0.3
    • Fix Version/s: Lucene.Net 3.0.3
    • Component/s: None
    • Labels:
      None

      Description

      We have several places where things are marked as obsolete and to be removed in 3.0. We should remove those. Also, care should be taken to comment what was removed (and what should be used in it's place), so that we can have complete and quality release notes.

        Activity

        Hide
        Christopher Currens added a comment -

        I did a quick search across the source in Lucene, and I think the LongParser and DoubleParser are the only two items in the entire source, marked obsoleted for removal in 3.0. There is one other object that is marked Obsolete to be removed in 3.x, but it is still in the 3.0.3 java code.

        I'm going to remove the obsolete attributes from those two interfaces listed, because of the differences of java and C# (not .NET), we can't match this API. Specifically, this reason is because even though Java and .NET allow static members and nested types (both static and instance types), it's invalid C# code, since it doesn't support it.

        Either way, since we can't conform to the exact API that java does for the FieldCache, it wouldn't be a bad idea to clean it up.

        Show
        Christopher Currens added a comment - I did a quick search across the source in Lucene, and I think the LongParser and DoubleParser are the only two items in the entire source, marked obsoleted for removal in 3.0. There is one other object that is marked Obsolete to be removed in 3.x, but it is still in the 3.0.3 java code. I'm going to remove the obsolete attributes from those two interfaces listed, because of the differences of java and C# (not .NET), we can't match this API. Specifically, this reason is because even though Java and .NET allow static members and nested types (both static and instance types), it's invalid C# code, since it doesn't support it. Either way, since we can't conform to the exact API that java does for the FieldCache, it wouldn't be a bad idea to clean it up.
        Hide
        Christopher Currens added a comment -

        I think they were changed to being nested in Lucene 3.0, but because of differences of Java and .NET, I don't think it was possible to do? (memory is foggy, but I think that's the case).

        Show
        Christopher Currens added a comment - I think they were changed to being nested in Lucene 3.0, but because of differences of Java and .NET, I don't think it was possible to do? (memory is foggy, but I think that's the case).
        Hide
        Prescott Nasser added a comment -

        LongParser and DoubleParser are marked as obsolete will be removed in 3.0. however, the cooresponding java code doesn't show as oboslete (http://svn.apache.org/viewvc/lucene/java/tags/lucene_3_0_3/src/java/org/apache/lucene/search/FieldCache.java?revision=1040994&view=markup).

        What am I missing?

        [Obsolete("Use FieldCache.LongParser, this will be removed in Lucene 3.0")]
        public interface LongParser:Parser

        { /// <summary>Return an long representation of this field's value. </summary> long ParseLong(System.String string_Renamed); }

        [Obsolete("Use FieldCache.DoubleParser, this will be removed in Lucene 3.0 ")]
        public interface DoubleParser:Parser

        { /// <summary>Return an long representation of this field's value. </summary> double ParseDouble(System.String string_Renamed); }
        Show
        Prescott Nasser added a comment - LongParser and DoubleParser are marked as obsolete will be removed in 3.0. however, the cooresponding java code doesn't show as oboslete ( http://svn.apache.org/viewvc/lucene/java/tags/lucene_3_0_3/src/java/org/apache/lucene/search/FieldCache.java?revision=1040994&view=markup ). What am I missing? [Obsolete("Use FieldCache.LongParser, this will be removed in Lucene 3.0")] public interface LongParser:Parser { /// <summary>Return an long representation of this field's value. </summary> long ParseLong(System.String string_Renamed); } [Obsolete("Use FieldCache.DoubleParser, this will be removed in Lucene 3.0 ")] public interface DoubleParser:Parser { /// <summary>Return an long representation of this field's value. </summary> double ParseDouble(System.String string_Renamed); }

          People

          • Assignee:
            Unassigned
            Reporter:
            Prescott Nasser
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development