Lucene.Net
  1. Lucene.Net
  2. LUCENENET-467

.NETify the public API where appropriate

    Details

      Description

      Although we haven't abandoned the line-by-line port of Java lucene, there are many idioms in Java that make little to no sense in a .NET assembly. The API can change to allow for a conventional .NET experience, while still maintaining the ability and ease during the porting process of Java logic.

      • Change Getxxx() and Setxxx() methods to .NET Properties
      • Implement the dispose pattern properly. Try, at all costs, to only use finalizers when necessary. They are expensive, and most of the classes used already have finalizers that will be called.
      • Convert Java Iterator-style classes (see TermEnum, TermDocs and others) to implement IEnumerable<T>
      • When catching exceptions, do not use throw; instead of throw ex; to maintain the stack trace

        Activity

        Christopher Currens created issue -
        Hide
        Luc Vanlerberghe added a comment -

        TopFieldCollector still has a Java-style create method (with lower case 'c')
        I'll submit a patch that changes it and all references to it.

        Show
        Luc Vanlerberghe added a comment - TopFieldCollector still has a Java-style create method (with lower case 'c') I'll submit a patch that changes it and all references to it.
        Luc Vanlerberghe made changes -
        Field Original Value New Value
        Attachment Lucenenet-467-create.patch [ 12530522 ]
        Hide
        Christopher Currens added a comment -

        Thanks. Patch applied in revision 1347715

        Show
        Christopher Currens added a comment - Thanks. Patch applied in revision 1347715
        Hide
        Christopher Currens added a comment -

        Moving to 3.5

        Show
        Christopher Currens added a comment - Moving to 3.5
        Christopher Currens made changes -
        Fix Version/s Lucene.Net 3.5 [ 12320145 ]
        Fix Version/s Lucene.Net 3.0.3 [ 12316215 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Christopher Currens
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0h
              0h
              Logged:
              Time Spent - 1m
              1m

                Development