[LUCENE-9998] The param 'fis' in StoredFieldsWriter.finish(FieldInfos fis, int numDocs) is never used

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 8.6.2
• Fix Version/s: 9.0
• Component/s: core/codecs
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: kkewwei
• Created: 11/Jun/21 08:43
• Updated: 28/Aug/22 16:22
• Resolved: 15/Jun/21 15:00

Description

We can see the `FieldInfos fis` in StoredFieldsWriter.finish(FieldInfos fis, int numDocs) is never used.

The class has four subclasses: Lucene90CompressingStoredFieldsWriter,Lucene50CompressingStoredFieldsWriter,CrankyStoredFieldsWriter,SimpleTextStoredFieldsWriter. the function `finish` in all four subclasses never use `fis`, if we could remove it from the function.

The same situation with the function `finish` in TermVectorsWriter.

Issue Links

• links to: GitHub Pull Request #183
• links to: GitHub Pull Request #741