Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-9991

Fix TestStringValueFacetCounts

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 9.0
    • 9.0, 8.9
    • modules/facet
    • None
    • New

    Description

      As reported by julietibs in LUCENE-9950, there's a randomized test failure in TestStringValueFacetCounts. It's actually an issue with the test itself.

      Since count ties are broken in StringValueFacetCounts by ordinal, but the test doesn't know anything about the ordinals, the test breaks ties by the value itself before comparing results. The edge-case is if we only request a topN of 1, but the top result ties in count with other results. In this scenario, the result returned by the Facets might be one that sorts higher than another when secondarily sorted by value, but the test can't solve for this since it only sees the one result. Should be a fairly simple fix in the test case itself. Will do so shortly.

      Attachments

        Activity

          People

            Unassigned Unassigned
            gsmiller Greg Miller
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h
                1h