[LUCENE-9864] Enforce @Override annotation with ecj static analysis configuration

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.0
• Component/s: general/build
• Labels: build
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Zach Chen
• Created: 24/Mar/21 03:38
• Updated: 28/Aug/22 16:18
• Resolved: 25/Mar/21 21:51

Description

This is a spin-off issue from https://issues.apache.org/jira/browse/LUCENE-9856, where ecj configuration was updated to catch dead code and lots of dead code was removed. In this issue, we would like to continue the clean up by enforcing @Override usage with org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=error configuration, and fix problems that arise. 

Issue Links

• is a clone of: LUCENE-9856 Improve static analysis to catch dead code and other potential bugs
• is cloned by: LUCENE-9883 Turn on ecj missingEnumCaseDespiteDefault setting
• relates to: LUCENE-9868 Verify checksums on generated files
• links to: GitHub Pull Request #40