> I got the patch to apply cleanly (see mailing list for details)
Thanks, Hoss! I'm using TortoiseSVN, I have to check how to set those
default properties for new files correctly.
> * just to clarify: IndexReader(Directory) is only around for
> backwards compatibility in subclasses right? And the only reason
> for the "private Directory" is to keep supporting the directory()
> method for any subclasses relying on it?
> * IndexReader() says it can be removed once the other constructor is
> removed ... why? is that just pointing out that we can rely on the
> default constructor?
Yes, just a suggested simplification. Keeping the constructor wouldn't hurt
> * since one of the goals is that IndexReaders which don't own their
> directory shouldn't utilize segmentInfos, would it make sense to
> eliminate directoryOwner from DirectoryIndexReader and instead test
> whether (null == segmentInfos) ?
Sounds good, will do...
> * the way TestMultiReader is setup with the "mode" is a bit confusing
> ... perhaps instead we should make a subclass where only openReader
> is overwritten (it will inherit the individual test methods) ?
Yes, that's cleaner, will make that change as well.
> here's the list of tweaks I made...
The improvements look good to me.
Thanks for the review, Hoss! I'll attach a new patch shortly.