Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-9658

Make 'precommit' an alias for gradle 'check' task.

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      A separate precommit task is clumsy and error prone. This was done to support back-compatibility with ant but I think it should be removed in favor of the gradle-convention 'check'.

      The only difference precommit currently has from check is that it doesn't run tests. People who want to bypass tests can still run check with:

      ./gradlew check -x test
      

      which excludes all test tasks from running.

      We can make precommit an alias to check at first (precommit.dependsOn check) and perhaps disable all tests manually so that it is compatible with the previous behavior. I'll add an info-box at the end to instruct people how to run check without tests too.

      The benefit of using check is that you can run it selectively on subprojects and that there is no need for extra plumbing to attach validation tasks to it.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dweiss Dawid Weiss
                Reporter:
                dweiss Dawid Weiss
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10m
                  10m