[LUCENE-9624] fix duplicate compute on maxUnpatchedValue

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.8
• Component/s: core/codecs
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Feng Guo
• Created: 30/Nov/20 12:17
• Updated: 28/Aug/22 16:11
• Resolved: 30/Nov/20 12:37

Description

in [LUCENE-9027|https://github.com/apache/lucene-solr/pull/973] lucene introduced SIMD to decode postings, which leaves a very small problem. i hope i can fix this as my first PR on this amazing project .

detail:

maxUnpatchedValue has already computed apache.lucene.codecs.lucene84.PForUtil#encode line 64
final long maxUnpatchedValue = (1L << patchedBitsRequired) - 1;

apache.lucene.codecs.lucene84.PForUtil#encode line 74
but computed later again:
if (longs[i] > (1L << patchedBitsRequired) - 1)...

Issue Links

• links to: GitHub Pull Request #2106