[LUCENE-9617] FieldNumbers.clear() should reset lowestUnassignedFieldNumber

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 8.7
• Fix Version/s: 8.8
• Component/s: core/index
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Michael Froh
• Created: 18/Nov/20 18:42
• Updated: 28/Aug/22 16:10
• Resolved: 19/Dec/20 15:13

Description

A call to IndexWriter.deleteAll() should completely reset the state of the index. Part of that is a call to globalFieldNumbersMap.clear(), which purges all knowledge of fields by clearing name -> number and number -> name maps. However, it does not reset lowestUnassignedFieldNumber.

If we have loop that adds some documents, calls deleteAll(), adds documents, etc. lowestUnassignedFieldNumber keeps counting up. Since FieldInfos allocates an array for number -> FieldInfo, this array will get larger and larger, effectively leaking memory.

We can fix this by resetting lowestUnassignedFieldNumber to -1 in FieldNumbers.clear().

I'll write a unit test and attach a patch.

Issue Links

• links to: GitHub Pull Request #2088