[LUCENE-9558] Clean up package name conflicts for analyzers-icu module

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.0
• Component/s: modules/analysis
• Lucene Fields: New
• Assignee: Tomoko Uchida
• Reporter: Tomoko Uchida
• Created: 03/Oct/20 16:15
• Updated: 28/Aug/22 16:09
• Resolved: 05/Oct/20 08:54

Description

analyzers-icu module shares the package names o.a.l.collation and o.a.l.collation.tokenattributes with analyzers-common; they need to be renamed.

There could be two solutions:

1. rename "o.a.l.collation" to "o.a.l.a.icu.collation"
2. move classes under "o.a.l.collation" to "o.a.l.a.icu" and classes under "o.a.l.collation.tokenattributes" to "o.a.l.a.icu.tokenattributes", and delete "o.a.l.collation" from analyzers-icu

I would prefer option 2. 1. may complicate the package hierarchy and there already exist o.a.l.a.icu.tokenattributes. (All classes under "o.a.l.collation" have prefix "ICUCollation", so I think we don't need to keep "collation" in the package name, do we?)

Issue Links

• is a child of: LUCENE-9499 Clean up package name conflicts between modules (split packages)
• links to: GitHub Pull Request #1946