Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-9558

Clean up package name conflicts for analyzers-icu module

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: main (9.0)
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      analyzers-icu module shares the package names o.a.l.collation and o.a.l.collation.tokenattributes with analyzers-common; they need to be renamed.

      There could be two solutions:

      1. rename "o.a.l.collation" to "o.a.l.a.icu.collation"
      2. move classes under "o.a.l.collation" to "o.a.l.a.icu" and classes under "o.a.l.collation.tokenattributes" to "o.a.l.a.icu.tokenattributes", and delete "o.a.l.collation" from analyzers-icu

      I would prefer option 2. 1. may complicate the package hierarchy and there already exist o.a.l.a.icu.tokenattributes. (All classes under "o.a.l.collation" have prefix "ICUCollation", so I think we don't need to keep "collation" in the package name, do we?)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                tomoko Tomoko Uchida
                Reporter:
                tomoko Tomoko Uchida
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m