Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-9513

Use seconds instead of millisecs

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: main (9.0), 8.6.2
    • Fix Version/s: main (9.0), 8.7
    • Component/s: core/other
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      In RangeFacetsExample, there is a trivial mistake where

      private final long nowSec is supposed to be secs.

      But it uses as millisecs.

      It doesn't affect the output due to the scale change (It will just make PAST_HOUR, PAST_SIX_HOURS not as intended). Still it's better to be correct.

       

      I've created a pull request on github with the simple fix.

      https://github.com/apache/lucene-solr/pull/1846

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                frankmanzhu Frank Zhu
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h