[LUCENE-9504] DocumentsWriterDeleteQueue.forceApplyGlobalSlice has needless locking

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.0
• Component/s: core/index
• Lucene Fields: New
• Assignee: Mike Drob
• Reporter: Mike Drob
• Created: 03/Sep/20 17:51
• Updated: 28/Aug/22 16:07
• Resolved: 08/Sep/20 15:13

Description

DocumentsWriterDeleteQueue.forceApplyGlobalSlice is only called from getBufferedUpdateTermsSize so we end up doing double the locking. It's not a huge problem because re-entrant locks are cheap, but we can probably unwrap the methods a little bit here.

This may impact HotSpot inlining, I haven't tried measuring that yet. If that is a concern, please let me know.

Issue Links

• links to: GitHub Pull Request #1826