[LUCENE-9501] IndexSortSortedNumericDocValuesRangeQuery violates iterator invariant.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.7
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Julie Tibshirani
• Created: 02/Sep/20 20:15
• Updated: 28/Aug/22 16:07
• Resolved: 11/Sep/20 22:38

Description

In LUCENE-7714 we added a new query to sandbox called IndexSortSortedNumericDocValuesRangeQuery that optimizes range calculations when the field is sorted. The query has a bad bug: its DocIdSetIterator can return an old value for docID() even after advance has returned NO_MORE_DOCS. This violates the DocIdSetIterator contract and means that it's possible for DocIdSetIterator#advance to be called when it's already been exhausted (which can result in invalid reads).

We would have expected this issue to be caught in tests, especially because classes like AssertingIndexSearcher check for these invariants. As part of this fix I'll look into improvements to the Asserting* wrapper framework.

Issue Links

• links to: GitHub Pull Request #1833