[LUCENE-9451] Sort.rewrite doesn't always return this when unchanged

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 8.7
• Fix Version/s: 9.0
• Component/s: core/search
• Lucene Fields: New
• Assignee: Mike Drob
• Reporter: Mike Drob
• Created: 10/Aug/20 16:26
• Updated: 28/Aug/22 16:05
• Resolved: 04/Sep/20 14:46

Description

Sort.rewrite doesn't always return this as advertised in the Javadoc even if the underlying fields are unchanged. This is because the comparison uses reference equality.

There are two solutions we can do here, 1) switch from reference equality to object equality, and 2) fix some of the underlying sort fields to not create unnecessary objects.

cc: jpountz romseygeek

Issue Links

• links to: GitHub Pull Request #1731