[LUCENE-9408] OneMerge#mergeFinish is called multiple times

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.0, 8.6
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Simon Willnauer
• Created: 17/Jun/20 21:25
• Updated: 28/Aug/22 16:04
• Resolved: 24/Jun/20 21:54

Description

After enforcing calling this method only once a random test caused OneMerge#mergeFinished to be called multiple times.

21:06:59    [junit4] Suite: org.apache.lucene.index.TestIndexFileDeleter
21:06:59    [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestIndexFileDeleter -Dtests.method=testExcInDeleteFile -Dtests.seed=BCFF67862FF6529B -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=haw-US -Dtests.timezone=Etc/Zulu -Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1
21:06:59    [junit4] FAILURE 0.04s J0 | TestIndexFileDeleter.testExcInDeleteFile <<<
21:06:59    [junit4]    > Throwable #1: java.lang.AssertionError
21:06:59    [junit4]    > 	at __randomizedtesting.SeedInfo.seed([BCFF67862FF6529B:518F81E5ACB0444E]:0)
21:06:59    [junit4]    > 	at org.apache.lucene.index.TestIndexFileDeleter.testExcInDeleteFile(TestIndexFileDeleter.java:525)
21:06:59    [junit4]    > 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
21:06:59    [junit4]    > 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
21:06:59    [junit4]    > 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
21:06:59    [junit4]    > 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
21:06:59    [junit4]    > 	at java.base/java.lang.Thread.run(Thread.java:834)

mergeFinished should only be called once.

Issue Links

• links to: GitHub Pull Request #1590