[LUCENE-9349] Avoid parsing all terms in TermInSetQuery.visit()

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.6
• Lucene Fields: New
• Assignee: Alan Woodward
• Reporter: Alan Woodward
• Created: 28/Apr/20 20:01
• Updated: 15/Jul/20 15:09
• Resolved: 29/Apr/20 13:49

Description

TermInSetQuery currently iterates through all its prefix-encoded terms in order to build an array to pass back to its visitor when visit() is called.  This seems like a waste, particularly when the visitor is not actually consuming the terms (for example, when doing a clause-count check before executing a search).  Instead TermInSetQuery should use consumeTermsMatching(), and we should change the signature of this method so that it takes a BytesRunAutomaton supplier to allow for lazy instantiation.

Issue Links

• links to: GitHub Pull Request #1465