[LUCENE-9348] Rework grouping tests to make it simpler to add new GroupSelector implementations

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.6
• Lucene Fields: New
• Assignee: Alan Woodward
• Reporter: Alan Woodward
• Created: 27/Apr/20 16:23
• Updated: 15/Jul/20 15:09
• Resolved: 04/May/20 11:56

Description

The grouping module tests currently all try and test both grouping by term and grouping by ValueSource. They are quite difficult to follow, however, and it is not at all easy to add tests for a new grouping type. We should refactor things into an abstract base class that can then be extended by tests for each specific grouping type.

Issue Links

• links to: GitHub Pull Request #1461