[LUCENE-9342] Collector's totalHitsThreshold should not be lower than numHits

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: master (9.0), 8.6
• Lucene Fields: New
• Assignee: Tomas Eduardo Fernandez Lobbe
• Reporter: Tomas Eduardo Fernandez Lobbe
• Created: 22/Apr/20 22:46
• Updated: 15/Jul/20 15:10
• Resolved: 23/Apr/20 20:28

Description

While looking at SOLR-13289 I noticed this situation. If I create a collector with numHits greater than totalHitsThreshold, and the number of hits in the query is somewhere between those two numbers, the collector’s totalHitRelation will be TotalHits.Relation.GREATER_THAN_OR_EQUAL_TO, however the count will be accurate in this case. While this doesn't violate the current contract, the totalHitRelation could be changed to TotalHits.Relation.EQUAL_TO