Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-9257

FSTLoadMode should not be BlockTree specific as it is used more generally in index package

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 8.6
    • None
    • None
    • New

    Description

      FSTLoadMode and its associate attribute key (static String) are currently defined in BlockTreeTermsReader, but they are actually used outside of BlockTree in the general "index" package.
      CheckIndex and ReadersAndUpdates are using these enum and attribute key to drive the FST load mode through the SegmentReader which is not specific to a postings format. They have an unnecessary dependency to BlockTreeTermsReader.

      We could move FSTLoadMode out of BlockTreeTermsReader, to make it a public enum of the "index" package. That way CheckIndex and ReadersAndUpdates do not import anymore BlockTreeTermsReader.
      This would also allow other postings formats to use the same enum (e.g. LUCENE-9254)

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            broustant Bruno Roustant
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 40m
                1h 40m

                Slack

                  Issue deployment