Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-9257

FSTLoadMode should not be BlockTree specific as it is used more generally in index package

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.6
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      FSTLoadMode and its associate attribute key (static String) are currently defined in BlockTreeTermsReader, but they are actually used outside of BlockTree in the general "index" package.
      CheckIndex and ReadersAndUpdates are using these enum and attribute key to drive the FST load mode through the SegmentReader which is not specific to a postings format. They have an unnecessary dependency to BlockTreeTermsReader.

      We could move FSTLoadMode out of BlockTreeTermsReader, to make it a public enum of the "index" package. That way CheckIndex and ReadersAndUpdates do not import anymore BlockTreeTermsReader.
      This would also allow other postings formats to use the same enum (e.g. LUCENE-9254)

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              broustant Bruno Roustant
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 40m
                1h 40m