Lucene - Core
  1. Lucene - Core
  2. LUCENE-923

Should SegmentTermPositionVector be public?

    Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      I'm wondering why SegmentTermPositionVector is public. It implements the public
      interface TermPositionVector. Should we remove "public"?

      1. lucene-923.patch
        2 kB
        Michael Busch

        Activity

        Hide
        Grant Ingersoll added a comment -

        +1

        Show
        Grant Ingersoll added a comment - +1
        Hide
        Michael Busch added a comment -

        There were no objections against making SegmentTermPositionVector
        package-private, so I will go ahead and commit this patch soon.

        Show
        Michael Busch added a comment - There were no objections against making SegmentTermPositionVector package-private, so I will go ahead and commit this patch soon.
        Hide
        Michael Busch added a comment -

        Committed to trunk & 2.2 branch.

        Show
        Michael Busch added a comment - Committed to trunk & 2.2 branch.

          People

          • Assignee:
            Michael Busch
            Reporter:
            Michael Busch
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development