Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-9191

Fix linefiledocs compression or replace in tests

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.6
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      LineFileDocs(random) is very slow, even to open. It does a very slow "random skip" through a gzip compressed file.

      For the analyzers tests, in LUCENE-9186 I simply removed its usage, since TestUtil.randomAnalysisString is superior, and fast. But we should address other tests using it, since LineFileDocs(random) is slow!

      I think it is also the case that every lucene test has probably tested every LineFileDocs line many times now, whereas randomAnalysisString will invent new ones.

      Alternatively, we could "fix" LineFileDocs(random), e.g. special compression options (in blocks)... deflate supports such stuff. But it would make it even hairier than it is now.

        Attachments

        1. LUCENE-9191.patch
          2 kB
          Michael McCandless
        2. LUCENE-9191.patch
          15 kB
          Michael McCandless
        3. LUCENE-9191.patch
          15 kB
          Michael McCandless

          Activity

            People

            • Assignee:
              mikemccand Michael McCandless
              Reporter:
              rcmuir Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: