Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-9045

Do not use TreeMap/TreeSet in BlockTree and PerFieldPostingsFormat

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.4
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      TreeMap/TreeSet is a heavy structure designed to dynamically sort keys. It's iterator is much less performant than a list iterator. We should not use it when we don't need the sorting capability once built.

      And this is the case in BlockTreeTermsReader and PerFieldPostingsFormat. We need a Map and to sort keys at building time. But once built, we don't need to sort anymore, we can use a simple list for iteration efficiency.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                bruno.roustant Bruno Roustant
                Reporter:
                bruno.roustant Bruno Roustant
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m