[LUCENE-9001] Race condition in SetOnce

• Type: Bug
• Status: Reopened
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 8.4
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Przemko Robakowski
• Created: 08/Oct/19 19:32
• Updated: 15/Sep/24 22:23
• Resolved: 14/Oct/19 18:19

Description

There is race condition in SetOnce that can cause code below fail with NullPointerException:

SetOnce<String> setOnce = new SetOnce<>();
new Thread(() -> setOnce.set("thread")).start();
try{
    setOnce.set("main");
} catch (SetOnce.AlreadySetException e){
    setOnce.get().hashCode(); //possible NPE!
}

This is caused by 2 separate write operations - 1 for set marker field and 1 for actual object. So it's possible that marker is already set to true (causing AlreadySetException on second write attempt) but object is still not set (causing NullPointerException).

This can be avoided by using single AtomicReference instead to serve both purposes.

Issue Links

• links to: GitHub Pull Request #931