Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8995

TopSuggestDocsCollector#collect should be able to signal rejection

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 8.2
    • Fix Version/s: None
    • Component/s: modules/suggest
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Currently the suggestion collectors collect() method has no way of signaling back to the caller whether the matched completion it received was indeed collected.

      While this is currenty always the case for the default TopSuggestDocsCollector, there are implementations that overwrite this with custom collection logic that also deduplicates based on e.g. docID and/or context. Currently if those completions are rejected, the calling TopNSearcher has no way of noting these rejections and might therefore terminate early, thus missing on completions that should be returned.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                cbuescher Christoph B├╝scher
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3h 50m
                  3h 50m