Lucene - Core
  1. Lucene - Core
  2. LUCENE-898

contrib/javascript is not packaged into releases

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: general/build
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      the contrib/javascript directory is (apparently) a collection of javascript utilities for lucene .. but it has not build files or any mechanism to package it, so it is excluded form releases.

        Activity

        Hide
        Erik Hatcher added a comment -

        My vote is to remove the javascript contrib area entirely. It doesn't really do all that much useful. I'd be surprised if anyone really uses it.

        Show
        Erik Hatcher added a comment - My vote is to remove the javascript contrib area entirely. It doesn't really do all that much useful. I'd be surprised if anyone really uses it.
        Hide
        Michael Busch added a comment -

        > My vote is to remove the javascript contrib area entirely.

        +1. It also seems that this package is unmaintained. No files have
        been changed since February 2005, when it was moved from the
        sandbox to contrib.

        Show
        Michael Busch added a comment - > My vote is to remove the javascript contrib area entirely. +1. It also seems that this package is unmaintained. No files have been changed since February 2005, when it was moved from the sandbox to contrib.
        Hide
        Otis Gospodnetic added a comment -

        I think the files have not changed in a while because they work. I believe Kelvin Tan (the author) used/uses this stuff somewhere. I'm typically for cleaning things up, but somehow I feel that this javascript stuff should be left alone (it ain't broken, is it?).

        Show
        Otis Gospodnetic added a comment - I think the files have not changed in a while because they work. I believe Kelvin Tan (the author) used/uses this stuff somewhere. I'm typically for cleaning things up, but somehow I feel that this javascript stuff should be left alone (it ain't broken, is it?).
        Hide
        Erik Hatcher added a comment -

        It may still work ok, but my hunch is that changes to the QueryParser have made this javascript code more deprecated than anything.

        Even if we removed it from svn, it historically would still be there in case anyone really needed it.

        Again, I am +1 for removing it entirely after running it by the java-user list to see if anyone desires it.

        Show
        Erik Hatcher added a comment - It may still work ok, but my hunch is that changes to the QueryParser have made this javascript code more deprecated than anything. Even if we removed it from svn, it historically would still be there in case anyone really needed it. Again, I am +1 for removing it entirely after running it by the java-user list to see if anyone desires it.
        Hide
        Otis Gospodnetic added a comment -

        I've emailed Kelvin and asked for his thoughts. Maybe he'll update this code, who knows.

        Show
        Otis Gospodnetic added a comment - I've emailed Kelvin and asked for his thoughts. Maybe he'll update this code, who knows.
        Hide
        Otis Gospodnetic added a comment -

        Kelvin says:

        "Hey otis, thanks for forwarding this to me.

        Fine with me to have it removed.."

        Show
        Otis Gospodnetic added a comment - Kelvin says: "Hey otis, thanks for forwarding this to me. Fine with me to have it removed.."
        Hide
        Otis Gospodnetic added a comment -

        I'll take care of this in a few days...it looks like nobody will miss it.

        Show
        Otis Gospodnetic added a comment - I'll take care of this in a few days...it looks like nobody will miss it.
        Hide
        Otis Gospodnetic added a comment -

        Done.

        D javascript/queryEscaper/luceneQueryEscaper.js
        D javascript/queryEscaper/testQueryEscaper.html
        D javascript/queryEscaper
        D javascript/queryConstructor/luceneQueryConstructor.js
        D javascript/queryConstructor/luceneQueryConstructor.html
        D javascript/queryConstructor/testQueryConstructor.html
        D javascript/queryConstructor
        D javascript/queryValidator/luceneQueryValidator.js
        D javascript/queryValidator/testQueryValidator.html
        D javascript/queryValidator
        D javascript

        Committed revision 781057.

        Show
        Otis Gospodnetic added a comment - Done. D javascript/queryEscaper/luceneQueryEscaper.js D javascript/queryEscaper/testQueryEscaper.html D javascript/queryEscaper D javascript/queryConstructor/luceneQueryConstructor.js D javascript/queryConstructor/luceneQueryConstructor.html D javascript/queryConstructor/testQueryConstructor.html D javascript/queryConstructor D javascript/queryValidator/luceneQueryValidator.js D javascript/queryValidator/testQueryValidator.html D javascript/queryValidator D javascript Committed revision 781057.

          People

          • Assignee:
            Otis Gospodnetic
            Reporter:
            Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development