[LUCENE-8979] Code Cleanup: Use entryset for map iteration wherever possible - part 2 possible.

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 8.2
• Fix Version/s: 8.4
• Assignee: Unassigned
• Reporter: Koen De Groote
• Created: 15/Sep/19 00:43
• Updated: 28/Aug/22 15:50
• Resolved: 14/Oct/19 18:18

Description

For some reason, not all issues had been picked up in the previous ticket. This should be all of them. My bad I suppose.

 

==========================

 

Simple, non-important code cleanup.

Again, to clarify, please don't bother yourself with this ticket on company time, on personal time you could be working on something that makes you money or improves the product for your feature personally.

 

This entire ticket is an afterthough. A look back at the code base that most people don't have the time for.

 

================

 

While true that using `entrySet()` is really only an improvement for traversing a TreeMap(at least that's how it was in JDK8), it's a good practice in general to use it over keySet(), if you then use that keyset to do an extra lookup to get the value as well as the key.

 

So that's what this ticket is.

 

All changes were done automatically via Intellij's built-in code analysis.

 

Putting this on LUCENE because code both in lucene and solr was changed.

Issue Links

• is a clone of: LUCENE-8975 Code Cleanup: Use entryset for map iteration wherever possible.
• links to: GitHub Pull Request #881