[LUCENE-892] CompoundFileReader's openInput produces streams that may do an extra buffer copy

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1
• Fix Version/s: 2.3
• Component/s: core/index
• Lucene Fields: New, Patch Available
• Assignee: Michael McCandless
• Reporter: Michael McCandless
• Created: 25/May/07 19:03
• Updated: 28/Aug/22 11:37
• Resolved: 04/Jul/07 17:01

Description

Spinoff of LUCENE-888.

The class for reading from a compound file (CompoundFileReader) has a
primary stream which is a BufferedIndexInput when that stream is from
an FSDirectory (which is the norm). That is one layer of buffering.

Then, when its openInput is called, a CSIndexInput is created which
also subclasses from BufferedIndexInput. That's a second layer of
buffering.

When a consumer actually uses that CSIndexInput to read, and a call to
readByte or readBytes runs out of what's in the first buffer, it will
go to refill its buffer. But that refill calls the first
BufferedIndexInput which in turn may refill its buffer (a double
copy) by reading the underlying stream.

Not sure how to fix it yet but we should change things to not do the
extra buffer copy.