Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8853

FileSwitchDirectory is broken if temp outputs are used

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: main (9.0), 8.2
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      FileSwitchDirectory basically doesn't work if tmp output are used for files that are explicitly mapped with extensions. here is a failing test:

      16:49:40    [junit4] Suite: org.apache.lucene.search.suggest.analyzing.BlendedInfixSuggesterTest
      16:49:40    [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=BlendedInfixSuggesterTest -Dtests.method=testBlendedSort_fieldWeightZero_shouldRankSuggestionsByPositionMatch -Dtests.seed=16D8C93DC8FE5192 -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=pt-LU -Dtests.timezone=US/Michigan -Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1
      16:49:40    [junit4] ERROR   0.05s J1 | BlendedInfixSuggesterTest.testBlendedSort_fieldWeightZero_shouldRankSuggestionsByPositionMatch <<<
      16:49:40    [junit4]    > Throwable #1: java.nio.file.AtomicMoveNotSupportedException: _0.fdx__0.tmp -> _0.fdx: source and dest are in different directories
      16:49:40    [junit4]    > 	at __randomizedtesting.SeedInfo.seed([16D8C93DC8FE5192:20E180A9490374CE]:0)
      16:49:40    [junit4]    > 	at org.apache.lucene.store.FileSwitchDirectory.rename(FileSwitchDirectory.java:201)
      16:49:40    [junit4]    > 	at org.apache.lucene.store.MockDirectoryWrapper.rename(MockDirectoryWrapper.java:231)
      16:49:40    [junit4]    > 	at org.apache.lucene.store.LockValidatingDirectoryWrapper.rename(LockValidatingDirectoryWrapper.java:56)
      16:49:40    [junit4]    > 	at org.apache.lucene.store.TrackingDirectoryWrapper.rename(TrackingDirectoryWrapper.java:64)
      16:49:40    [junit4]    > 	at org.apache.lucene.store.FilterDirectory.rename(FilterDirectory.java:89)
      16:49:40    [junit4]    > 	at org.apache.lucene.index.SortingStoredFieldsConsumer.flush(SortingStoredFieldsConsumer.java:56)
      16:49:40    [junit4]    > 	at org.apache.lucene.index.DefaultIndexingChain.flush(DefaultIndexingChain.java:152)
      16:49:40    [junit4]    > 	at org.apache.lucene.index.DocumentsWriterPerThread.flush(DocumentsWriterPerThread.java:468)
      16:49:40    [junit4]    > 	at org.apache.lucene.index.DocumentsWriter.doFlush(DocumentsWriter.java:555)
      16:49:40    [junit4]    > 	at org.apache.lucene.index.DocumentsWriter.flushAllThreads(DocumentsWriter.java:722)
      16:49:40    [junit4]    > 	at org.apache.lucene.index.IndexWriter.prepareCommitInternal(IndexWriter.java:3199)
      16:49:40    [junit4]    > 	at org.apache.lucene.index.IndexWriter.commitInternal(IndexWriter.java:3444)
      16:49:40    [junit4]    > 	at org.apache.lucene.index.IndexWriter.commit(IndexWriter.java:3409)
      16:49:40    [junit4]    > 	at org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.commit(AnalyzingInfixSuggester.java:345)
      16:49:40    [junit4]    > 	at org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.build(AnalyzingInfixSuggester.java:315)
      16:49:40    [junit4]    > 	at org.apache.lucene.search.suggest.analyzing.BlendedInfixSuggesterTest.getBlendedInfixSuggester(BlendedInfixSuggesterTest.java:125)
      16:49:40    [junit4]    > 	at org.apache.lucene.search.suggest.analyzing.BlendedInfixSuggesterTest.testBlendedSort_fieldWeightZero_shouldRankSuggestionsByPositionMatch(BlendedInfixSuggesterTest.java:79)
      16:49:40    [junit4]    > 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      16:49:40    [junit4]    > 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      16:49:40    [junit4]    > 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      16:49:40    [junit4]    > 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
      16:49:40    [junit4]    > 	at java.base/java.lang.Thread.run(Thread.java:834)
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              simonw Simon Willnauer

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 10m
                1h 10m

                  Issue deployment