[LUCENE-8849] DocValuesRewriteMethod.visit should visit the MTQ

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 8.6
• Component/s: core/search
• Lucene Fields: New
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 10/Jun/19 17:55
• Updated: 28/Aug/22 15:46
• Resolved: 11/Mar/20 21:00

Description

The DocValuesRewriteMethod implements the QueryVisitor API (visit method) in a way that surprises me.  It does not visit the wrapped MTQ query.  Shouldn't it?  Here is what I think it should do, similar to other query wrappers:

    @Override
    public void visit(QueryVisitor visitor) {
      query.visit(visitor.getSubVisitor(BooleanClause.Occur.MUST, this));
    }

CC romseygeek