Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8847

Code Cleanup: Rewrite StringBuilder.append with concatted strings

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: main (9.0), 8.2
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      EDIT: Again, to clarify, please don't bother yourself with this ticket on company time, on personal time you could be working on something that makes you money or improves the product for your feature personally.

       

      This entire ticket is an afterthough. A look back at the code base that most people don't have the time for.

      ---------

       

      Code cleanup as suggested by static analysis tools. Will be done in my spare time.

      If someone reviews this, please also do not take up actual time from your work to do that. I do not wish to take away from your working hours.

       

      These are simple, trivial things, that were probably overlooked or not even considered(which isn't an accusation or something negative). But also stuff that the Java compiler/JIT won't optimize on its own.

       

      That's what static analysis tool are good for: picking stuff like that up.

       

      I'm talking about Intellij's static code analysis. Facebook's "Infer" for Java. Google's "errorprone", etc...

      These are the kinds of things that, frankly, for the people actually working on real features, are very time consuming, not even part of the feature, and have a very low chance of actually turning up a real performance issue.

      So I'm opting to have a look at the results of these tools and implementing the sensible stuff and if something bigger pops up I'll make a separate ticket for those things individually.

       

      Creating this ticket so I can name a branch after it.

       

      The only questions I have are: since the code base is so large, do I apply each subject to all parts of it? Or only core? How do I split it up?

      Do I make multiple PRs with this one ticket? Or do I make multiple tickets and give each their own PR?

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                uschindler Uwe Schindler
                Reporter:
                KoenDG Koen De Groote
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: