Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8843

Only ignore IOException on dirs when invoking force

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: main (9.0), 8.2
    • Component/s: core/other
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      I think the IOException suppression in IOUtils#fsync when fsyncing directories is too broad, it suppresses any IOException that occurs in this method if isDir is true. For example, it causes exceptions opening non-existent directories, if access is denied to the directory, or general filesystem errors to be suppressed. To me that feels like it could be suppressing application bugs, or at least exceptions an application would want to know about. Instead, the IOException suppression should only apply after we have successfully opened the directory. I submitted a PR to propose a change along these lines: https://github.com/apache/lucene-solr/pull/706. Please let me know what you think.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                jasontedor Jason E Tedor
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10m
                  10m