[LUCENE-8843] Only ignore IOException on dirs when invoking force

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.0, 8.2
• Component/s: core/other
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Jason E Tedor
• Created: 07/Jun/19 23:45
• Updated: 22/Nov/24 01:41
• Resolved: 11/Jun/19 08:36

Description

I think the IOException suppression in IOUtils#fsync when fsyncing directories is too broad, it suppresses any IOException that occurs in this method if isDir is true. For example, it causes exceptions opening non-existent directories, if access is denied to the directory, or general filesystem errors to be suppressed. To me that feels like it could be suppressing application bugs, or at least exceptions an application would want to know about. Instead, the IOException suppression should only apply after we have successfully opened the directory. I submitted a PR to propose a change along these lines: https://github.com/apache/lucene-solr/pull/706. Please let me know what you think.

Issue Links

• links to: GitHub Pull Request #706