[LUCENE-8814] Use forbiddenapis to block explicit GCs

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: general/build
• Lucene Fields: New
• Assignee: Shawn Heisey
• Reporter: Shawn Heisey
• Created: 26/May/19 18:22
• Updated: 28/Aug/22 15:45

Description

Explicit GCs should not be allowed in production code.

We do have a number of System.gc() calls in Lucene and Solr tests, and in the Lucene benchmark.

I intend to block System.gc() and Runtime.gc() in the forbidden APIs configuration. As part of that, I need to know whether the explicit calls in the test and benchmark code should be left there and allowed with SuppressForbidden, or if we should remove them. My general thought is that production code will most likely not be doing explicit GCs, so tests shouldn't be doing it either ... but I didn't design those tests, so I can't claim to know the intent.