[LUCENE-8804] FieldType attribute map should not be modifiable after freeze

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 8.0
• Fix Version/s: 9.0, 8.2
• Component/s: core/index
• Labels: features patch
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Vamshi Gudavarthi
• Created: 17/May/19 19:06
• Updated: 28/Aug/22 15:45
• Resolved: 20/May/19 18:22

Description

Today FieldType attribute map can be modifiable even after freeze. For all other properties of FieldType, we do "checkIfFrozen()" before making the update to the property but for attribute map, we does not seem to make such check. 

 

https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.0.0/lucene/core/src/java/org/apache/lucene/document/FieldType.java#L363

we may need to add check at the beginning of the function similar to other properties setters.