[LUCENE-8726] WrappedDoubleValuesSource can leak IndexSearcher references

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.7.2, 8.1
• Lucene Fields: New
• Assignee: Alan Woodward
• Reporter: Alan Woodward
• Created: 14/Mar/19 10:03
• Updated: 28/Aug/22 15:42
• Resolved: 29/Mar/19 13:05

Description

Cause of SOLR-13315

Index-specific DoubleValuesSources can be created by DoubleValuesSource.rewrite(), and the various consumers of these sources are careful not to store these rewritten sources on long-lived objects, such as queries that may be re-used between searchers.  However, the bridge code between ValueSource and DoubleValuesSource does not return a new object from its rewrite method, instead caching the passed-in IndexSearcher, which means references to this searcher may leak.

Issue Links

• causes: SOLR-13315 Possible SolrIndexSearcher leak through LogWatcher and FunctionScoreQuery