Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-869

Make FSIndexInput and FSIndexOutput inner classes of FSDirectory

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: core/store
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      I would like make FSIndexInput and FSIndexOutput protected, static, inner classes of FSDirectory. Currently these classes are located in the same source file as FSDirectory, which means that classes outside the store package can not extend them.

      I don't see any performance impacts or other side effects of this trivial patch. All unit tests pass.

      1. lucene-869.patch
        7 kB
        Michael Busch

        Activity

        Hide
        michaelbusch Michael Busch added a comment -

        Attaching the patch file. If nobody objects I'm going to commit this soon.

        Show
        michaelbusch Michael Busch added a comment - Attaching the patch file. If nobody objects I'm going to commit this soon.
        Hide
        cutting Doug Cutting added a comment -

        Heh. These classes precede the addition of nested classes to Java. They're nine years old! +1

        Show
        cutting Doug Cutting added a comment - Heh. These classes precede the addition of nested classes to Java. They're nine years old! +1
        Hide
        michaelbusch Michael Busch added a comment -

        Funny, I didn't even know that nested classes weren't in Java forever...

        I just committed this.

        Show
        michaelbusch Michael Busch added a comment - Funny, I didn't even know that nested classes weren't in Java forever... I just committed this.

          People

          • Assignee:
            michaelbusch Michael Busch
            Reporter:
            michaelbusch Michael Busch
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development