[LUCENE-8683] Synchronize JavaCC tasks with actual Java code

• Type: Task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 8.x, 9.0
• Component/s: general/build
• Lucene Fields: New, Patch Available
• Assignee: Unassigned
• Reporter: Nikolay Khitrin
• Created: 07/Feb/19 14:38
• Updated: 28/Aug/22 15:41

Description

Changes list:

1. Apply SOLR-11662 changes back to Solr QueryParser.jj
2. Move jj_3R_7 method in Solr QueryParser.java back to generated position after SOLR-9185 merge.
3. Incorporate deprecated methods removal in CharStream by SOLR-8764 to ant build via regexps.
4. Incorporate unused imports removal by LUCENE-7319 to ant build via regexps.
5. Remove unused import from Lucene surround/parser/QueryParser.jj
6. Move license header from PARSER_BEGIN/PARSER_END block in Lucene flexible/standard/parser/StandardSyntaxParser.jj
7. Update JavaCC's OriginalChecksum lines to actual for Lucene flexible standard parser utility classes.

Cumulative effect of this patch:

• Actual query parsing code remains unchanged.
• ant javacc (both lucene/queryparser and solr/core) now left source tree intact.

Final thoughts:

• I’m not very happy with this tricky regexp replacements, maybe we should pick some special tool for sources postprocessing.
• It will be great to develop a special precommit task to ensure metasource and source consistency.

Patch removing Lucene CharStream deprecated methods extracted to sub-task for master branch only.

Sub-Tasks

• Remove deprecated CharStream methods: Open