[LUCENE-8637] WeightedSpanTermExtractor unnexessarily enforces rewrite for some SpanQueiries

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 7.4, 7.3.1, 7.5, 7.6
• Component/s: modules/highlighter
• Labels: patch
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Christoph Goller
• Created: 14/Jan/19 17:25
• Updated: 28/Aug/22 15:40

Description

Method mustRewriteQuery(SpanQuery) returns true for SpanPositionCheckQuery, SpanContainingQuery, SpanWithinQuery, and SpanBoostQuery, however, these queries do not require rewriting. One effect of this is e.g. that UnifiedHighlighter does not work with OffsetSource Postings and switches to Analysis which of course has consequences for performance.

I attach a patch for lucene version 7.6.0. I have not checked whether it breaks existing unit tests.

Issue Links

• is related to: LUCENE-10477 SpanBoostQuery.rewrite was incomplete for boost==1 factor