Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8579

Don't run badapples when building a release

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.6, 8.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Nick pinged me because his attempt to build a release failed because of Solr test failures. When looking at those, I noticed that a number of them were known flaky test that are already tagged as bad apples, eg. org.apache.solr.cloud.TestStressInPlaceUpdates.stressTest.

      We should disable badapples in the script to build a release, ie. something like

      diff --git a/dev-tools/scripts/buildAndPushRelease.py b/dev-tools/scripts/buildAndPushRelease.py
      index 5a8f5cc..b557da2 100644
      --- a/dev-tools/scripts/buildAndPushRelease.py
      +++ b/dev-tools/scripts/buildAndPushRelease.py
      @@ -105,7 +105,7 @@ def prepare(root, version, gpgKeyID, gpgPassword):
         print('  Check DOAP files')
         checkDOAPfiles(version)
       
      -  print('  ant clean test validate documentation-lint')
      +  print('  ant -Dtests.badapples=false clean test validate documentation-lint')
      -  run('ant clean test validate documentation-lint')
      +  run('ant -Dtests.badapples=false clean test validate documentation-lint')
       
         open('rev.txt', mode='wb').write(rev.encode('UTF-8'))
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jpountz Adrien Grand
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: